From b59ec53dd0324dcf017cbdb33c7eedb4a6721db4 Mon Sep 17 00:00:00 2001 From: Rahul Kashyap Date: Sun, 28 Jan 2018 18:20:43 +0530 Subject: [PATCH 1/3] Update index.d.ts --- types/johnny-five/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/types/johnny-five/index.d.ts b/types/johnny-five/index.d.ts index 95a348429d..689a78050a 100644 --- a/types/johnny-five/index.d.ts +++ b/types/johnny-five/index.d.ts @@ -510,10 +510,10 @@ export declare module Led { on(): void; off(): void; - color(value: number): void; + color(value: string): void; toggle(): void; strobe(ms: number): void; - brightness(value: number): void; + intensity(value: number): void; fadeIn(ms: number): void; fadeOut(ms: number): void; pulse(ms: number): void; From 4332ab9682e82eba77ffe4f09b78278d5269e9a2 Mon Sep 17 00:00:00 2001 From: Rahul Kashyap Date: Sun, 11 Feb 2018 11:24:51 +0530 Subject: [PATCH 2/3] Update index.d.ts --- types/johnny-five/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/types/johnny-five/index.d.ts b/types/johnny-five/index.d.ts index 689a78050a..f394d67c56 100644 --- a/types/johnny-five/index.d.ts +++ b/types/johnny-five/index.d.ts @@ -510,10 +510,10 @@ export declare module Led { on(): void; off(): void; - color(value: string): void; + color(value: string): void; // color method expects string. toggle(): void; strobe(ms: number): void; - intensity(value: number): void; + intensity(value: number): void; // intensity is the correct method here instead of brightness. fadeIn(ms: number): void; fadeOut(ms: number): void; pulse(ms: number): void; From 2bac294b89913d45acfd608e92cb2c4e719a23cc Mon Sep 17 00:00:00 2001 From: Daniel Rosenwasser Date: Wed, 28 Feb 2018 15:00:58 -0800 Subject: [PATCH 3/3] Remove comments. --- types/johnny-five/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/types/johnny-five/index.d.ts b/types/johnny-five/index.d.ts index f394d67c56..689a78050a 100644 --- a/types/johnny-five/index.d.ts +++ b/types/johnny-five/index.d.ts @@ -510,10 +510,10 @@ export declare module Led { on(): void; off(): void; - color(value: string): void; // color method expects string. + color(value: string): void; toggle(): void; strobe(ms: number): void; - intensity(value: number): void; // intensity is the correct method here instead of brightness. + intensity(value: number): void; fadeIn(ms: number): void; fadeOut(ms: number): void; pulse(ms: number): void;