kylefang/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/zhigang1992/DefinitelyTyped.git synced 2026-04-26 06:05:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Correct @types/three TubeGeometry path argument (#13475)

Browse Source 
Despite being called "path," `TubeGeometry` requires a Vector3 curve. I think this came from someone misreading the docs (https://threejs.org/docs/#Reference/Geometries/TubeGeometry), where it identifies the first argument like this:

```
path — Curve - A path that inherits from the Curve base class
```

The "Curve" in the description links to https://threejs.org/docs/#Reference/Extras.Core/Curve.

A `Path`, meanwhile, comes from a list of Vector2s, which seems totally incompatible.
This commit is contained in:
Chris Grigg
2016-12-27 19:43:08 -05:00
committed by Andy
parent 9a32cea0ad
commit 962bd3a273
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
three/index.d.ts vendored
View File

@@ -6483,10 +6483,10 @@ declare namespace THREE {
}
export class TubeGeometry extends Geometry {
constructor(path: Path, segments?: number, radius?: number, radiusSegments?: number, closed?: boolean, taper?: (u: number) => number);
constructor(path: Curve<Vector3>, segments?: number, radius?: number, radiusSegments?: number, closed?: boolean, taper?: (u: number) => number);
parameters: {
path: Path;
path: Curve<Vector3>;
segments: number;
radius: number;
radialSegments: number;