From 89ded17f34ec409ff8f2a3e5b1697e7362c35f48 Mon Sep 17 00:00:00 2001 From: Aleksei Tsikov Date: Mon, 26 Feb 2018 21:56:03 +0200 Subject: [PATCH] [events] Set removeAllListeners argument as optional (#23828) * Set removeAllListeners argument as optional * Update version properly --- types/events/events-tests.ts | 6 ++++++ types/events/index.d.ts | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/types/events/events-tests.ts b/types/events/events-tests.ts index ccf89c1402..67fe352225 100644 --- a/types/events/events-tests.ts +++ b/types/events/events-tests.ts @@ -53,6 +53,12 @@ setTimeout(() => { emitter.removeAllListeners('send'); }, 3000); +setTimeout(() => { + console.log('\n'); + emitter.emit('send', 'params1'); + emitter.removeAllListeners(); +}, 3000); + setTimeout(() => { console.log('\n'); emitter.emit(1); diff --git a/types/events/index.d.ts b/types/events/index.d.ts index 85ce0a7b0e..c9b08a4575 100644 --- a/types/events/index.d.ts +++ b/types/events/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for events 1.1 +// Type definitions for events 1.2 // Project: https://github.com/Gozala/events // Definitions by: Yasunori Ohoka // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped @@ -15,7 +15,7 @@ export class EventEmitter { on(type: string | number, listener: Listener): this; once(type: string | number, listener: Listener): this; removeListener(type: string | number, listener: Listener): this; - removeAllListeners(type: string | number): this; + removeAllListeners(type?: string | number): this; listeners(type: string | number): Listener[]; listenerCount(type: string | number): number; }