From 8f6bd06104b6512e9820145454ed241ea56ea664 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tarnay=20K=C3=A1lm=C3=A1n?= Date: Sun, 20 May 2018 21:54:47 +0200 Subject: [PATCH 1/2] [react-aria-menubutton] onSelection is optional since 5.1.1 no other api changes since 5.0 according to the project's change log --- types/react-aria-menubutton/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/types/react-aria-menubutton/index.d.ts b/types/react-aria-menubutton/index.d.ts index 52a77e7435..6866719f3c 100644 --- a/types/react-aria-menubutton/index.d.ts +++ b/types/react-aria-menubutton/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for react-aria-menubutton 5.0 +// Type definitions for react-aria-menubutton 5.1.1 // Project: https://github.com/davidtheclark/react-aria-menubutton // Definitions by: Muhammad Fawwaz Orabi // Chris Rohlfs @@ -19,7 +19,7 @@ export interface WrapperProps * It will be passed the value of the selected `MenuItem` and * the React `SyntheticEvent`. */ - onSelection(value: any, event: React.SyntheticEvent): any; + onSelection?(value: any, event: React.SyntheticEvent): any; /** * A callback to run when the menu is opened or closed. From 7e99b9efc855d9b3051581f7f74affe04bdce2c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tarnay=20K=C3=A1lm=C3=A1n?= Date: Sun, 20 May 2018 22:10:13 +0200 Subject: [PATCH 2/2] [react-aria-menubutton] drop patch version to make CI happy --- types/react-aria-menubutton/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/react-aria-menubutton/index.d.ts b/types/react-aria-menubutton/index.d.ts index 6866719f3c..f7a4ef7de0 100644 --- a/types/react-aria-menubutton/index.d.ts +++ b/types/react-aria-menubutton/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for react-aria-menubutton 5.1.1 +// Type definitions for react-aria-menubutton 5.1 // Project: https://github.com/davidtheclark/react-aria-menubutton // Definitions by: Muhammad Fawwaz Orabi // Chris Rohlfs