From f05f79fd5836003f29930c96f2a3c6e77bfb81df Mon Sep 17 00:00:00 2001 From: Arthur Cinader Date: Thu, 17 Dec 2015 10:34:51 -0800 Subject: [PATCH] Add remove() to ionic.modal.IonicModalController Per api: http://ionicframework.com/docs/api/controller/ionicModal/ note the note in the ionic source code: "Be sure to call [remove()](#remove) when you are done with each modal to clean it up and avoid memory leaks." https://github.com/driftyco/ionic/blob/af1bfef327e685585244c6051c4d38b98aa6c62a/js/angular/service/modal.js#L87 --- ionic/ionic-tests.ts | 1 + ionic/ionic.d.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/ionic/ionic-tests.ts b/ionic/ionic-tests.ts index 9c5cfdad0c..bad5f9d9f1 100644 --- a/ionic/ionic-tests.ts +++ b/ionic/ionic-tests.ts @@ -149,6 +149,7 @@ class IonicTestController { ionicModalController.initialize(modalOptions); ionicModalController.show().then(() => console.log("shown modal")) ionicModalController.hide().then(() => console.log("hid modal")) + ionicModalController.remove().then(() => console.log("removed modal")) var isShown: boolean = ionicModalController.isShown(); this.$ionicModal.fromTemplateUrl("templateUrl", modalOptions) diff --git a/ionic/ionic.d.ts b/ionic/ionic.d.ts index ce097a2265..a3781f26d0 100644 --- a/ionic/ionic.d.ts +++ b/ionic/ionic.d.ts @@ -174,6 +174,7 @@ declare module ionic { initialize(options: IonicModalOptions): void; show(): ng.IPromise; hide(): ng.IPromise; + remove(): ng.IPromise; isShown(): boolean; }