From 9081e075b730c9948b643a6c38d6deb18cb0ebdd Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Mon, 23 May 2016 17:25:06 -0700 Subject: [PATCH 1/2] Fix extend erro for `NodeBuffer` With change https://github.com/Microsoft/TypeScript/pull/8515, `Uint8Array.fill` method now returns `this`. Fixing definition of `NodeBuffer` to maintain extends relationship with `Uint8Array` --- node/node-4.d.ts | 2 +- node/node.d.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/node/node-4.d.ts b/node/node-4.d.ts index a9d4709a91..0cd3c54a17 100644 --- a/node/node-4.d.ts +++ b/node/node-4.d.ts @@ -465,7 +465,7 @@ interface NodeBuffer extends Uint8Array { writeFloatBE(value: number, offset: number, noAssert?: boolean): number; writeDoubleLE(value: number, offset: number, noAssert?: boolean): number; writeDoubleBE(value: number, offset: number, noAssert?: boolean): number; - fill(value: any, offset?: number, end?: number): Buffer; + fill(value: any, offset?: number, end?: number): this; // TODO: encoding param indexOf(value: string | number | Buffer, byteOffset?: number): number; // TODO: entries diff --git a/node/node.d.ts b/node/node.d.ts index 8c30f25809..42621d50c4 100644 --- a/node/node.d.ts +++ b/node/node.d.ts @@ -465,7 +465,7 @@ interface NodeBuffer extends Uint8Array { writeFloatBE(value: number, offset: number, noAssert?: boolean): number; writeDoubleLE(value: number, offset: number, noAssert?: boolean): number; writeDoubleBE(value: number, offset: number, noAssert?: boolean): number; - fill(value: any, offset?: number, end?: number): Buffer; + fill(value: any, offset?: number, end?: number): this; // TODO: encoding param indexOf(value: string | number | Buffer, byteOffset?: number): number; // TODO: entries From 94b221dd73f1ed85741ac114bbbea9f36c16a59a Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Mon, 23 May 2016 17:27:55 -0700 Subject: [PATCH 2/2] Remove unreachable code --- node/node-0.11-tests.ts | 3 ++- node/node-0.12-tests.ts | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/node/node-0.11-tests.ts b/node/node-0.11-tests.ts index 8609639a8c..66c0c9ec7c 100644 --- a/node/node-0.11-tests.ts +++ b/node/node-0.11-tests.ts @@ -24,7 +24,8 @@ assert.notStrictEqual(2, "2", "uses === comparator"); assert.throws(() => { throw "a hammer at your face"; }, undefined, "DODGED IT"); assert.doesNotThrow(() => { - if (false) { throw "a hammer at your face"; } + const b = false; + if (b) { throw "a hammer at your face"; } }, undefined, "What the...*crunch*"); //////////////////////////////////////////////////// diff --git a/node/node-0.12-tests.ts b/node/node-0.12-tests.ts index 2560181896..989b69dab0 100644 --- a/node/node-0.12-tests.ts +++ b/node/node-0.12-tests.ts @@ -26,7 +26,8 @@ assert.notStrictEqual(2, "2", "uses === comparator"); assert.throws(() => { throw "a hammer at your face"; }, undefined, "DODGED IT"); assert.doesNotThrow(() => { - if (false) { throw "a hammer at your face"; } + const b = false; + if (b) { throw "a hammer at your face"; } }, undefined, "What the...*crunch*"); ////////////////////////////////////////////////////