From 75cfa7a0083ded5bcba6926f2b0201976b2e81c3 Mon Sep 17 00:00:00 2001 From: Andrew MacLeay Date: Mon, 18 Jun 2018 17:57:53 -0400 Subject: [PATCH 1/2] Add newer option names to storybook__addon-options Following https://github.com/storybooks/storybook/pull/1692/files ``` showLeftPanel -> showStoriesPanel showDownPanel -> showAddonPanel downPanelInRight -> addonPanelInRight ``` --- types/storybook__addon-options/index.d.ts | 10 +++++++--- .../storybook__addon-options-tests.ts | 13 +++++++++++++ 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/types/storybook__addon-options/index.d.ts b/types/storybook__addon-options/index.d.ts index 9e5876101d..d9d5f661f0 100644 --- a/types/storybook__addon-options/index.d.ts +++ b/types/storybook__addon-options/index.d.ts @@ -2,6 +2,7 @@ // Project: https://github.com/storybooks/storybook // Definitions by: Joscha Feth // Simon Helle Nielsen +// A.MacLeay // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.3 @@ -9,10 +10,13 @@ export interface Options { name?: string; url?: string; goFullScreen?: boolean; - showLeftPanel?: boolean; - showDownPanel?: boolean; + showLeftPanel?: boolean; // deprecated, use showStoriesPanel + showStoriesPanel?: boolean; + showDownPanel?: boolean; // deprecated; use showAddonPanel + showAddonPanel?: boolean; showSearchBox?: boolean; - downPanelInRight?: boolean; + downPanelInRight?: boolean; // deprecated; use addonPanelInRight + addonPanelInRight?: boolean; sortStoriesByKind?: boolean; hierarchySeparator?: RegExp | string; hierarchyRootSeparator?: RegExp | string; diff --git a/types/storybook__addon-options/storybook__addon-options-tests.ts b/types/storybook__addon-options/storybook__addon-options-tests.ts index c19307564c..239b9625e8 100644 --- a/types/storybook__addon-options/storybook__addon-options-tests.ts +++ b/types/storybook__addon-options/storybook__addon-options-tests.ts @@ -4,6 +4,19 @@ setOptions({ name: 'My Storybook', url: 'https://example.com', goFullScreen: false, + showStoriesPanel: false, + showAddonPanel: false, + showSearchBox: false, + addonPanelInRight: false, + sortStoriesByKind: false, + hierarchySeparator: /\//, + hierarchyRootSeparator: /\|/ +}); + +setOptions({ + name: 'My Storybook - deprecated options', + url: 'https://example.com', + goFullScreen: false, showLeftPanel: false, showDownPanel: false, showSearchBox: false, From c5990d7b9e9b3ef0fe2e0927cdaff96b3e80a6d5 Mon Sep 17 00:00:00 2001 From: Andrew MacLeay Date: Mon, 18 Jun 2018 18:07:49 -0400 Subject: [PATCH 2/2] Add selectedAddonPanel to storybook__addon-options Following https://github.com/storybooks/storybook/pull/1641 --- types/storybook__addon-options/index.d.ts | 1 + .../storybook__addon-options/storybook__addon-options-tests.ts | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/types/storybook__addon-options/index.d.ts b/types/storybook__addon-options/index.d.ts index d9d5f661f0..61f9f11def 100644 --- a/types/storybook__addon-options/index.d.ts +++ b/types/storybook__addon-options/index.d.ts @@ -20,6 +20,7 @@ export interface Options { sortStoriesByKind?: boolean; hierarchySeparator?: RegExp | string; hierarchyRootSeparator?: RegExp | string; + selectedAddonPanel?: string; } export function setOptions(options: Options): void; diff --git a/types/storybook__addon-options/storybook__addon-options-tests.ts b/types/storybook__addon-options/storybook__addon-options-tests.ts index 239b9625e8..a3003c913f 100644 --- a/types/storybook__addon-options/storybook__addon-options-tests.ts +++ b/types/storybook__addon-options/storybook__addon-options-tests.ts @@ -10,7 +10,8 @@ setOptions({ addonPanelInRight: false, sortStoriesByKind: false, hierarchySeparator: /\//, - hierarchyRootSeparator: /\|/ + hierarchyRootSeparator: /\|/, + selectedAddonPanel: 'storybook/actions/action-panel', }); setOptions({