kylefang/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/zhigang1992/DefinitelyTyped.git synced 2026-04-23 21:00:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improvement to node type definition (#10037)

Browse Source 
case 2. Improvement to existing type definition.

From Node.js API Reference (https://nodejs.org/dist/latest-v6.x/docs/api/fs.html#fs_fs_open_path_flags_mode_callback):

fs.open(path, flags[, mode], callback)#
Added in: v0.0.2
path <String> | <Buffer>
flags <String> | <Number>
mode <Integer>
callback <Function>

Only mode is optional in open. Also instead of pure function overloads definitions can be re-written using union type annotaion for open and openSync.
This commit is contained in:
Ivo Stratev
2016-07-09 14:40:37 +03:00
committed by Masahiro Wakame
parent 7234823908
commit 77b1b17093
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
node/node.d.ts vendored
View File

@@ -1541,11 +1541,9 @@ declare module "fs" {
export function readdirSync(path: string | Buffer): string[];
export function close(fd: number, callback?: (err?: NodeJS.ErrnoException) => void): void;
export function closeSync(fd: number): void;
export function open(path: string | Buffer, flags: string, callback?: (err: NodeJS.ErrnoException, fd: number) => any): void;
export function open(path: string | Buffer, flags: number, mode: number, callback?: (err: NodeJS.ErrnoException, fd: number) => any): void;
export function open(path: string | Buffer, flags: string, mode: number, callback?: (err: NodeJS.ErrnoException, fd: number) => any): void;
export function openSync(path: string | Buffer, flags: number, mode?: number): number;
export function openSync(path: string | Buffer, flags: string, mode?: number): number;
export function open(path: string | Buffer, flags: string | number, callback: (err: NodeJS.ErrnoException, fd: number) => void): void;
export function open(path: string | Buffer, flags: string | number, mode: number, callback: (err: NodeJS.ErrnoException, fd: number) => void): void;
export function openSync(path: string | Buffer, flags: string | number, mode?: number): number;
export function utimes(path: string | Buffer, atime: number, mtime: number, callback?: (err?: NodeJS.ErrnoException) => void): void;
export function utimes(path: string | Buffer, atime: Date, mtime: Date, callback?: (err?: NodeJS.ErrnoException) => void): void;
export function utimesSync(path: string | Buffer, atime: number, mtime: number): void;