From 567377968c0c3d249a45cd712fb9e60d0e2152bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Anton=20Str=C3=B6mkvist?= Date: Thu, 3 Aug 2017 18:57:02 +0200 Subject: [PATCH] Use correct type for rc-tooltip's overlay (#18579) The previous type signature doesn't allow e.g. strings to be passed in, even though they're completely valid. --- types/rc-tooltip/index.d.ts | 3 ++- types/rc-tooltip/rc-tooltip-tests.tsx | 7 +++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/types/rc-tooltip/index.d.ts b/types/rc-tooltip/index.d.ts index 84068dd920..c24f0018fd 100644 --- a/types/rc-tooltip/index.d.ts +++ b/types/rc-tooltip/index.d.ts @@ -1,6 +1,7 @@ // Type definitions for rc-tooltip v3.4.2 // Project: https://github.com/react-component/tooltip // Definitions by: rhysd +// ahstro // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.3 @@ -26,7 +27,7 @@ declare namespace Tooltip { placement?: Placement | Object; align?: Object; onPopupAlign?: (popupDomNode: Element, align: Object) => void; - overlay: React.ReactElement | (() => React.ReactElement); + overlay: React.ReactNode; arrowContent?: React.ReactNode; getTooltipContainer?: () => Element; destroyTooltipOnHide?: boolean; diff --git a/types/rc-tooltip/rc-tooltip-tests.tsx b/types/rc-tooltip/rc-tooltip-tests.tsx index 751ffc43ec..832a292e97 100644 --- a/types/rc-tooltip/rc-tooltip-tests.tsx +++ b/types/rc-tooltip/rc-tooltip-tests.tsx @@ -9,6 +9,13 @@ ReactDOM.render( document.querySelector('.app') ); +ReactDOM.render( + + hover + , + document.querySelector('.app') +); + ReactDOM.render(