From 9b0e0aabfb90b91e84f68bcf61022442f43e98d7 Mon Sep 17 00:00:00 2001
From: Claas Ahlrichs <claasahl@gmail.com>
Date: Tue, 5 Jun 2018 06:53:06 +0200
Subject: [PATCH 1/5] added "value" parameter to "valueProcessors" and
 "attrValueProcessors"

---
 types/xml2js/index.d.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/types/xml2js/index.d.ts b/types/xml2js/index.d.ts
index 248f29814b..1875399e23 100644
--- a/types/xml2js/index.d.ts
+++ b/types/xml2js/index.d.ts
@@ -34,7 +34,7 @@ export interface Options {
     async?: boolean;
     attrkey?: string;
     attrNameProcessors?: Array<(name: string) => any>;
-    attrValueProcessors?: Array<(name: string) => any>;
+    attrValueProcessors?: Array<(value: string, name: string) => any>;
     charkey?: string;
     charsAsChildren?: boolean;
     childkey?: string;
@@ -52,7 +52,7 @@ export interface Options {
     tagNameProcessors?: Array<(name: string) => any>;
     trim?: boolean;
     validator?: Function;
-    valueProcessors?: Array<(name: string) => any>;
+    valueProcessors?: Array<(value: string, name: string) => any>;
     xmlns?: boolean;
 }
 

From e51382786f7d9f7f924ab6d3d22f5998cdbb379e Mon Sep 17 00:00:00 2001
From: Claas Ahlrichs <claasahl@gmail.com>
Date: Wed, 6 Jun 2018 11:16:30 +0200
Subject: [PATCH 2/5] added Claas Ahlrichs to "Definitions By"

---
 types/xml2js/index.d.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/types/xml2js/index.d.ts b/types/xml2js/index.d.ts
index 1875399e23..42fc669da4 100644
--- a/types/xml2js/index.d.ts
+++ b/types/xml2js/index.d.ts
@@ -5,6 +5,7 @@
 //                 Christopher Currens <https://github.com/ccurrens>
 //                 Edward Hinkle <https://github.com/edwardhinkle>
 //                 Behind The Math <https://github.com/BehindTheMath>
+//                 Claas Ahlrichs <https://github.com/claasahl>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
 
 /// <reference types="node"/>

From a132409be6236cf39560ccb4367f06118e14e0c1 Mon Sep 17 00:00:00 2001
From: Claas Ahlrichs <claasahl@gmail.com>
Date: Wed, 6 Jun 2018 11:43:49 +0200
Subject: [PATCH 3/5] updated version number and declared "name" parameter as
 optional

---
 types/xml2js/index.d.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/types/xml2js/index.d.ts b/types/xml2js/index.d.ts
index 42fc669da4..4a123a2f03 100644
--- a/types/xml2js/index.d.ts
+++ b/types/xml2js/index.d.ts
@@ -1,4 +1,4 @@
-// Type definitions for node-xml2js 0.4
+// Type definitions for node-xml2js 0.4.6
 // Project: https://github.com/Leonidas-from-XIV/node-xml2js
 // Definitions by: Michel Salib <https://github.com/michelsalib>
 //                 Jason McNeil <https://github.com/jasonrm>
@@ -35,7 +35,7 @@ export interface Options {
     async?: boolean;
     attrkey?: string;
     attrNameProcessors?: Array<(name: string) => any>;
-    attrValueProcessors?: Array<(value: string, name: string) => any>;
+    attrValueProcessors?: Array<(value: string, name?: string) => any>;
     charkey?: string;
     charsAsChildren?: boolean;
     childkey?: string;
@@ -53,7 +53,7 @@ export interface Options {
     tagNameProcessors?: Array<(name: string) => any>;
     trim?: boolean;
     validator?: Function;
-    valueProcessors?: Array<(value: string, name: string) => any>;
+    valueProcessors?: Array<(value: string, name?: string) => any>;
     xmlns?: boolean;
 }
 

From d8b2358f2a0b7882509cfb7303a3f1effb301f7b Mon Sep 17 00:00:00 2001
From: Claas Ahlrichs <claasahl@gmail.com>
Date: Wed, 6 Jun 2018 11:52:30 +0200
Subject: [PATCH 4/5] Expected: foo MAJOR.MINOR (patch version not allowed)

---
 types/xml2js/index.d.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/types/xml2js/index.d.ts b/types/xml2js/index.d.ts
index 4a123a2f03..bc8250af19 100644
--- a/types/xml2js/index.d.ts
+++ b/types/xml2js/index.d.ts
@@ -1,4 +1,4 @@
-// Type definitions for node-xml2js 0.4.6
+// Type definitions for node-xml2js 0.4
 // Project: https://github.com/Leonidas-from-XIV/node-xml2js
 // Definitions by: Michel Salib <https://github.com/michelsalib>
 //                 Jason McNeil <https://github.com/jasonrm>

From 6f72c2699daedc2abaed3b71d1b6ff9feecaf6de Mon Sep 17 00:00:00 2001
From: Claas Ahlrichs <claasahl@gmail.com>
Date: Wed, 6 Jun 2018 12:22:35 +0200
Subject: [PATCH 5/5] REVERTED: declared "name" parameter as optional

---
 types/xml2js/index.d.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/types/xml2js/index.d.ts b/types/xml2js/index.d.ts
index bc8250af19..42fc669da4 100644
--- a/types/xml2js/index.d.ts
+++ b/types/xml2js/index.d.ts
@@ -35,7 +35,7 @@ export interface Options {
     async?: boolean;
     attrkey?: string;
     attrNameProcessors?: Array<(name: string) => any>;
-    attrValueProcessors?: Array<(value: string, name?: string) => any>;
+    attrValueProcessors?: Array<(value: string, name: string) => any>;
     charkey?: string;
     charsAsChildren?: boolean;
     childkey?: string;
@@ -53,7 +53,7 @@ export interface Options {
     tagNameProcessors?: Array<(name: string) => any>;
     trim?: boolean;
     validator?: Function;
-    valueProcessors?: Array<(value: string, name?: string) => any>;
+    valueProcessors?: Array<(value: string, name: string) => any>;
     xmlns?: boolean;
 }