From 8bda20406b42295a84de6f414bc270fe118ece67 Mon Sep 17 00:00:00 2001 From: NN Date: Tue, 20 Jan 2015 15:36:55 +0200 Subject: [PATCH 1/2] Update definitions according to the documentation https://developer.chrome.com/extensions/webNavigation --- chrome/chrome.d.ts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/chrome/chrome.d.ts b/chrome/chrome.d.ts index 782b6c78f7..26fd57e559 100755 --- a/chrome/chrome.d.ts +++ b/chrome/chrome.d.ts @@ -2089,11 +2089,20 @@ declare module chrome.webNavigation { interface GetFrameResultDetails { url: string; errorOccurred: boolean; + parentFrameId: number; } interface GetAllFrameDetails { tabId: number; } + + interface GetAllFrameResultDetails { + url: string; + errorOccurred: boolean; + processId: number; + frameId: number; + parentFrameId: number; + } interface ReferenceFragmentUpdatedDetails { processId: number; @@ -2144,6 +2153,7 @@ declare module chrome.webNavigation { url: string; timeStamp: number; frameId: number; + parentFrameId: number; } interface CommittedDetails { @@ -2214,7 +2224,7 @@ declare module chrome.webNavigation { } export function getFrame(details: GetFrameDetails, callback: (details?: GetFrameResultDetails) => void): void; - export function getAllFrames(details: GetAllFrameDetails, callback: (details?: Object[]) => void): void; + export function getAllFrames(details: GetAllFrameDetails, callback: (details?: GetAllFrameResultDetails[]) => void): void; var onReferenceFragmentUpdated: WebNavigationReferenceFragmentUpdatedEvent; var onCompleted: WebNavigationCompletedEvent; From 8e95fc38ebe96e56f7a65f45bd64c1e7a9f7d992 Mon Sep 17 00:00:00 2001 From: NN Date: Sat, 24 Jan 2015 19:11:13 +0200 Subject: [PATCH 2/2] Update chrome.d.ts --- chrome/chrome.d.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/chrome/chrome.d.ts b/chrome/chrome.d.ts index 26fd57e559..a5321d8537 100755 --- a/chrome/chrome.d.ts +++ b/chrome/chrome.d.ts @@ -2096,12 +2096,9 @@ declare module chrome.webNavigation { tabId: number; } - interface GetAllFrameResultDetails { - url: string; - errorOccurred: boolean; + interface GetAllFrameResultDetails extends GetFrameResultDetails { processId: number; frameId: number; - parentFrameId: number; } interface ReferenceFragmentUpdatedDetails {