From e4119e7bd75c7177ce076bef4816b1d561aaf3ec Mon Sep 17 00:00:00 2001 From: Roland Hummel Date: Wed, 29 Jul 2015 22:35:39 +0200 Subject: [PATCH 1/2] Making optional parameter optional angular.translate.ITranslateProvider has the method useLoader that can be invoked with just one parameter, too (see http://angular-translate.github.io/docs/#/guide/13_custom-loaders#customer-loaders_make-use-of-a-custom-loader) --- angular-translate/angular-translate.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/angular-translate/angular-translate.d.ts b/angular-translate/angular-translate.d.ts index 1abb13ae81..ab4c1db5f5 100644 --- a/angular-translate/angular-translate.d.ts +++ b/angular-translate/angular-translate.d.ts @@ -93,7 +93,7 @@ declare module angular.translate { storageKey(key: string): void; // JeroMiya - the library should probably return ITranslateProvider but it doesn't here useUrlLoader(url: string): ITranslateProvider; useStaticFilesLoader(options: IStaticFilesLoaderOptions): ITranslateProvider; - useLoader(loaderFactory: string, options: any): ITranslateProvider; + useLoader(loaderFactory: string, options?: any): ITranslateProvider; useLocalStorage(): ITranslateProvider; useCookieStorage(): ITranslateProvider; useStorage(storageFactory: any): ITranslateProvider; From ee173f2819fed5bd49d06c5d16ffc4922c180c23 Mon Sep 17 00:00:00 2001 From: Roland Hummel Date: Wed, 29 Jul 2015 22:58:58 +0200 Subject: [PATCH 2/2] Updating test so that it also invokes useLoader. --- angular-translate/angular-translate-tests.ts | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/angular-translate/angular-translate-tests.ts b/angular-translate/angular-translate-tests.ts index cc02a85d6a..c60247f427 100644 --- a/angular-translate/angular-translate-tests.ts +++ b/angular-translate/angular-translate-tests.ts @@ -2,6 +2,14 @@ var app = angular.module('at', ['pascalprecht.translate']); +app.factory('customLoader', ($q:angular.IQService) => { + return (options:any) => { + var dfd:angular.IDeferred = $q.defer(); + dfd.resolve('whatever you wanted to translate, I simply know nothing about the language with the key ' + options.key); + return dfd.promise; + } +}); + app.config(($translateProvider: angular.translate.ITranslateProvider) => { $translateProvider.translations('en', { TITLE: 'Hello', @@ -16,6 +24,8 @@ app.config(($translateProvider: angular.translate.ITranslateProvider) => { BUTTON_LANG_DE: 'deutsch' }); $translateProvider.preferredLanguage('en'); + + $translateProvider.useLoader('customLoader'); }); interface Scope extends ng.IScope {