kylefang/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/zhigang1992/DefinitelyTyped.git synced 2026-04-23 21:00:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

angular.js bugfix - interface ILogProvider extends IServiceProvider (missing .$get method)

Browse Source 
There is a [`$logProvider`](https://docs.angularjs.org/api/ng/provider/$logProvider) in angular, here are the relevant source lines: https://github.com/angular/angular.js/blob/master/src/ng/log.js#L47-L67. It contains `.$get` method.

in Denifitely Typed, there is only:

```
    interface ILogProvider {
        debugEnabled(): boolean;
        debugEnabled(enabled: boolean): ILogProvider;
    }
```

(https://github.com/borisyankov/DefinitelyTyped/blob/master/angularjs/angular.d.ts#L865-L868). Note, there is no `.$get` method. THe interface should have extended ``IServiceProvider , i.e. `interface ILogProvider extends IServiceProvider`.
This commit is contained in:
Tomasz Ducin
2015-07-22 10:36:59 +02:00
parent 6baa15a0d7
commit 2c389556cc
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
angularjs/angular.d.ts vendored
View File

@@ -862,7 +862,7 @@ declare module angular {
warn: ILogCall;
}
interface ILogProvider {
interface ILogProvider extends IServiceProvider {
debugEnabled(): boolean;
debugEnabled(enabled: boolean): ILogProvider;
}