From fab68fe2e91119fff60169e0df77695e29fff9a9 Mon Sep 17 00:00:00 2001 From: Derek Finlinson Date: Thu, 31 May 2018 10:02:37 -0600 Subject: [PATCH 1/4] Make formParameters optional for Xrm.Navigation.openForm --- types/xrm/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/xrm/index.d.ts b/types/xrm/index.d.ts index 18d8cae218..8521a198e8 100644 --- a/types/xrm/index.d.ts +++ b/types/xrm/index.d.ts @@ -4378,7 +4378,7 @@ declare namespace Xrm { /** * Opens an entity form or a quick create form. */ - openForm(entityFormOptions: Navigation.EntityFormOptions, formParameters: Utility.OpenParameters): Async.PromiseLike; + openForm(entityFormOptions: Navigation.EntityFormOptions, formParameters?: Utility.OpenParameters): Async.PromiseLike; /** * Opens a URL, including file URLs. From 4f7e3eac4adb1ee9cf9bca3f57b7ea7faf2de4f0 Mon Sep 17 00:00:00 2001 From: Derek Finlinson Date: Thu, 31 May 2018 10:32:47 -0600 Subject: [PATCH 2/4] Add interface for OpenFormResult --- types/xrm/index.d.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/types/xrm/index.d.ts b/types/xrm/index.d.ts index 8521a198e8..7be5205c24 100644 --- a/types/xrm/index.d.ts +++ b/types/xrm/index.d.ts @@ -4198,6 +4198,13 @@ declare namespace Xrm { confirmed: boolean; } + interface OpenFormResult { + /** + * Identifies the record displayed or created + */ + savedEntityReference: LookupValue[] + } + /** * Details to show in the Error dialog */ @@ -4378,7 +4385,7 @@ declare namespace Xrm { /** * Opens an entity form or a quick create form. */ - openForm(entityFormOptions: Navigation.EntityFormOptions, formParameters?: Utility.OpenParameters): Async.PromiseLike; + openForm(entityFormOptions: Navigation.EntityFormOptions, formParameters?: Utility.OpenParameters): Async.PromiseLike; /** * Opens a URL, including file URLs. From e30046775d6b5a52a9f5bfdc5b18886a522a80b0 Mon Sep 17 00:00:00 2001 From: Derek Finlinson Date: Thu, 31 May 2018 10:49:59 -0600 Subject: [PATCH 3/4] Missing semicolon --- types/xrm/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/xrm/index.d.ts b/types/xrm/index.d.ts index 7be5205c24..511fcc1083 100644 --- a/types/xrm/index.d.ts +++ b/types/xrm/index.d.ts @@ -4202,7 +4202,7 @@ declare namespace Xrm { /** * Identifies the record displayed or created */ - savedEntityReference: LookupValue[] + savedEntityReference: LookupValue[]; } /** From 270e304ab614062f54fa943fb205f3f30fd50c20 Mon Sep 17 00:00:00 2001 From: Derek Finlinson Date: Mon, 4 Jun 2018 08:32:19 -0600 Subject: [PATCH 4/4] Fix other Navigation methods --- types/xrm/index.d.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/types/xrm/index.d.ts b/types/xrm/index.d.ts index 511fcc1083..fdb6504e96 100644 --- a/types/xrm/index.d.ts +++ b/types/xrm/index.d.ts @@ -4361,26 +4361,26 @@ declare namespace Xrm { * @param alertStrings The strings to be used in the alert dialog. * @param alertOptions The height and width options for alert dialog */ - openAlertDialog(alertStrings: Navigation.AlertStrings, alertOptions: Navigation.DialogSizeOptions): Async.PromiseLike; + openAlertDialog(alertStrings: Navigation.AlertStrings, alertOptions?: Navigation.DialogSizeOptions): Async.PromiseLike; /** * Displays a confirmation dialog box containing a message and two buttons. * @param confirmStrings The strings to be used in the confirm dialog. * @param confirmOptions The height and width options for alert dialog */ - openConfirmDialog(confirmStrings: Navigation.ConfirmStrings, confirmOptions: Navigation.DialogSizeOptions): Async.PromiseLike; + openConfirmDialog(confirmStrings: Navigation.ConfirmStrings, confirmOptions?: Navigation.DialogSizeOptions): Async.PromiseLike; /** * Displays an error dialog. * @param confirmStrings The strings to be used in the confirm dialog. * @param confirmOptions The height and width options for alert dialog */ - openConfirmDialog(errorOptions: Navigation.ErrorDialogOptions): Async.PromiseLike; + openErrorDialog(errorOptions: Navigation.ErrorDialogOptions): Async.PromiseLike; /** * Opens a file. */ - openFile(file: Navigation.FileDetails, openFileOptions: XrmEnum.OpenFileOptions): void; + openFile(file: Navigation.FileDetails, openFileOptions?: XrmEnum.OpenFileOptions): void; /** * Opens an entity form or a quick create form.