From 1a20dc303b7a9f8180747e26f145d1ebad3bee93 Mon Sep 17 00:00:00 2001 From: Christian Rackerseder Date: Thu, 24 May 2018 07:46:15 +0200 Subject: [PATCH] Fix return type of ready() function --- types/loadjs/index.d.ts | 2 +- types/loadjs/test/loadjs-tests.ts | 4 ++-- types/loadjs/test/loadjs-umd-tests.ts | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/types/loadjs/index.d.ts b/types/loadjs/index.d.ts index e68875e53a..9373308815 100644 --- a/types/loadjs/index.d.ts +++ b/types/loadjs/index.d.ts @@ -27,7 +27,7 @@ declare namespace loadjs { error?(depsNotFound: string): void; } - function ready(bundleIds: string | string[], optionsOrCallback: ReadyOptions | LoadedFn): void; + function ready(bundleIds: string | string[], optionsOrCallback: ReadyOptions | LoadedFn): typeof loadjs; function isDefined(bundleId: string): boolean; function done(bundleId: string): void; function reset(): void; diff --git a/types/loadjs/test/loadjs-tests.ts b/types/loadjs/test/loadjs-tests.ts index e61df50ec8..0b3aad142d 100644 --- a/types/loadjs/test/loadjs-tests.ts +++ b/types/loadjs/test/loadjs-tests.ts @@ -16,8 +16,8 @@ const readyOptions: importedLoadJs.ReadyOptions = { importedLoadJs('/path/to/foo.js', () => {}); importedLoadJs(['/path/to/foo.js', '/path/to/bar.js'], () => {}); importedLoadJs(['/path/to/foo.js', '/path/to/bar.js'], 'foobar'); -importedLoadJs.ready('foobar', () => {}); -importedLoadJs.ready(['foo', 'bar'], () => {}); +importedLoadJs.ready('foobar', () => {}).ready('foobar', () => {}); +importedLoadJs.ready(['foo', 'bar'], () => {}).ready(['foo', 'bar'], () => {}); importedLoadJs.isDefined('foobar'); importedLoadJs(['/path/to/foo.js', '/path/to/bar.js'], 'foobar', loadOptions); importedLoadJs.ready('foobar', readyOptions); diff --git a/types/loadjs/test/loadjs-umd-tests.ts b/types/loadjs/test/loadjs-umd-tests.ts index 1a35f04c43..94ee4f5090 100644 --- a/types/loadjs/test/loadjs-umd-tests.ts +++ b/types/loadjs/test/loadjs-umd-tests.ts @@ -1,8 +1,8 @@ loadjs('/path/to/foo.js', () => {}); loadjs(['/path/to/foo.js', '/path/to/bar.js'], () => {}); loadjs(['/path/to/foo.js', '/path/to/bar.js'], 'foobar'); -loadjs.ready('foobar', () => {}); -loadjs.ready(['foo', 'bar'], () => {}); +loadjs.ready('foobar', () => {}).ready('foobar', () => {}); +loadjs.ready(['foo', 'bar'], () => {}).ready(['foo', 'bar'], () => {}); loadjs.isDefined('foobar'); loadjs(['/path/to/foo.js', '/path/to/bar.js'], 'foobar', { before: (path, scriptEl) => {},