From ae611d0aa6a8f8022d1685dece0a23d375d94c95 Mon Sep 17 00:00:00 2001
From: Matt <begincalendar@gmail.com>
Date: Wed, 6 Sep 2017 09:33:36 +1000
Subject: [PATCH 1/2] Add: Some test cases.

---
 types/react-select/react-select-tests.tsx | 37 +++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/types/react-select/react-select-tests.tsx b/types/react-select/react-select-tests.tsx
index 7ac189f231..15527339b1 100644
--- a/types/react-select/react-select-tests.tsx
+++ b/types/react-select/react-select-tests.tsx
@@ -186,6 +186,43 @@ describe("Examples", () => {
         }
     });
 
+    it("onValueClick", () => {
+        class Component extends React.Component {
+            private onValueClick: ReactSelect.OnValueClickHandler<number> = (option) => {
+                const optionValue: number = option.value;
+            }
+
+            render() {
+                const options = [
+                    { value: 3, label: "Option 3" },
+                    { value: 9, label: "Option 9" }
+                ];
+
+                return <ReactSelect
+                    name="select"
+                    value={123}
+                    options={options}
+                />;
+            }
+        }
+    });
+
+    it("Custom value onValueClick", () => {
+        class Component extends React.Component {
+            private onValueClick: ReactSelect.OnValueClickHandler<CustomValueType> = (option) => {
+                const optionValue: CustomValueType = option.value;
+            }
+
+            render() {
+                return <CustomValueReactSelect
+                    name="select"
+                    value={EXAMPLE_CUSTOM_VALUE}
+                    options={EXAMPLE_CUSTOM_OPTIONS}
+                />;
+            }
+        }
+    });
+
     it("Custom value onChange", () => {
         class Component extends React.Component {
             private onSelectChange: ReactSelect.OnChangeSingleHandler<CustomValueType> = (option) => {

From 5a412fbc878e350d0557f85ffc75a23499b5076a Mon Sep 17 00:00:00 2001
From: Matt <begincalendar@gmail.com>
Date: Wed, 6 Sep 2017 09:43:09 +1000
Subject: [PATCH 2/2] Fix: OnValueClickHandler type now gets Option<TValue> as
 first parameter, not a string value.

---
 types/react-select/index.d.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/types/react-select/index.d.ts b/types/react-select/index.d.ts
index eae34b6905..15831caa44 100644
--- a/types/react-select/index.d.ts
+++ b/types/react-select/index.d.ts
@@ -40,7 +40,7 @@ declare namespace ReactSelectClass {
     type OnBlurHandler = React.FocusEventHandler<HTMLDivElement | HTMLInputElement>;
     type OptionRendererHandler<TValue = OptionValues> = (option: Option<TValue>) => HandlerRendererResult;
     type ValueRendererHandler<TValue = OptionValues> = (option: Option<TValue>) => HandlerRendererResult;
-    type OnValueClickHandler = (value: string, event: React.MouseEvent<HTMLAnchorElement>) => void;
+    type OnValueClickHandler<TValue = OptionValues> = (option: Option<TValue>, event: React.MouseEvent<HTMLAnchorElement>) => void;
     type IsOptionUniqueHandler<TValue = OptionValues> = (arg: { option: Option<TValue>, options: Options<TValue>, labelKey: string, valueKey: string }) => boolean;
     type IsValidNewOptionHandler = (arg: { label: string }) => boolean;
     type NewOptionCreatorHandler<TValue = OptionValues> = (arg: { label: string, labelKey: string, valueKey: string }) => Option<TValue>;
@@ -421,7 +421,7 @@ declare namespace ReactSelectClass {
         /**
          * onClick handler for value labels: function (value, event) {}
          */
-        onValueClick?: OnValueClickHandler;
+        onValueClick?: OnValueClickHandler<TValue>;
 
         /**
          *  pass the value to onChange as a simple value (legacy pre 1.0 mode), defaults to false