kylefang/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/zhigang1992/DefinitelyTyped.git synced 2026-05-24 13:59:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #19573 from begincalendar/fix-19536

Browse Source 
[react-select] Fix #19536 - OnValueClickHandler string "value" type to Option<TValue> "option" type
This commit is contained in:
Arthur Ozga
2017-09-14 14:25:18 -07:00
committed by GitHub
parent a0d8a3f2f6 5a412fbc87
commit 197c0670ea
2 changed files with 39 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
types/react-select/index.d.ts vendored
View File

@@ -41,7 +41,7 @@ declare namespace ReactSelectClass {
type OnBlurHandler = React.FocusEventHandler<HTMLDivElement | HTMLInputElement>;
type OptionRendererHandler<TValue = OptionValues> = (option: Option<TValue>) => HandlerRendererResult;
type ValueRendererHandler<TValue = OptionValues> = (option: Option<TValue>) => HandlerRendererResult;
type OnValueClickHandler = (value: string, event: React.MouseEvent<HTMLAnchorElement>) => void;
type OnValueClickHandler<TValue = OptionValues> = (option: Option<TValue>, event: React.MouseEvent<HTMLAnchorElement>) => void;
type IsOptionUniqueHandler<TValue = OptionValues> = (arg: { option: Option<TValue>, options: Options<TValue>, labelKey: string, valueKey: string }) => boolean;
type IsValidNewOptionHandler = (arg: { label: string }) => boolean;
type NewOptionCreatorHandler<TValue = OptionValues> = (arg: { label: string, labelKey: string, valueKey: string }) => Option<TValue>;
@@ -427,7 +427,7 @@ declare namespace ReactSelectClass {
/**
* onClick handler for value labels: function (value, event) {}
*/
onValueClick?: OnValueClickHandler;
onValueClick?: OnValueClickHandler<TValue>;
/**
* pass the value to onChange as a simple value (legacy pre 1.0 mode), defaults to false

37
types/react-select/react-select-tests.tsx
View File

@@ -186,6 +186,43 @@ describe("Examples", () => {
}
});
it("onValueClick", () => {
class Component extends React.Component {
private onValueClick: ReactSelect.OnValueClickHandler<number> = (option) => {
const optionValue: number = option.value;
}
render() {
const options = [
{ value: 3, label: "Option 3" },
{ value: 9, label: "Option 9" }
];
return <ReactSelect
name="select"
value={123}
options={options}
/>;
}
}
});
it("Custom value onValueClick", () => {
class Component extends React.Component {
private onValueClick: ReactSelect.OnValueClickHandler<CustomValueType> = (option) => {
const optionValue: CustomValueType = option.value;
}
render() {
return <CustomValueReactSelect
name="select"
value={EXAMPLE_CUSTOM_VALUE}
options={EXAMPLE_CUSTOM_OPTIONS}
/>;
}
}
});
it("Custom value onChange", () => {
class Component extends React.Component {
private onSelectChange: ReactSelect.OnChangeSingleHandler<CustomValueType> = (option) => {