From 0f3d1dc1702afeedc8a8771f573be860d86be9fb Mon Sep 17 00:00:00 2001 From: Daniel Milbrandt Date: Wed, 3 Jan 2018 21:19:08 +0100 Subject: [PATCH] ClusterSetupMasterSettings to ClusterSettings (#22647) According to official docs the settings for setupMaster settings are just the ClusterSettings. There is an ClusterSettings interface already but setupMaster function parameters refered to incomplete and unnecessary ClusterSetupMasterSettings. I deleted the ClusterSetupMasterSettings interface and refer to the existing ClusterSettings which are correct. https://nodejs.org/docs/latest-v8.x/api/cluster.html#cluster_cluster_setupmaster_settings --- types/node/index.d.ts | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/types/node/index.d.ts b/types/node/index.d.ts index 86f4b40823..c96e1965b1 100644 --- a/types/node/index.d.ts +++ b/types/node/index.d.ts @@ -1178,13 +1178,6 @@ declare module "cluster" { gid?: number; } - export interface ClusterSetupMasterSettings { - exec?: string; // default: process.argv[1] - args?: string[]; // default: process.argv.slice(2) - silent?: boolean; // default: false - stdio?: any[]; - } - export interface Address { address: string; port: number; @@ -1269,7 +1262,7 @@ declare module "cluster" { isWorker: boolean; // TODO: cluster.schedulingPolicy settings: ClusterSettings; - setupMaster(settings?: ClusterSetupMasterSettings): void; + setupMaster(settings?: ClusterSettings): void; worker?: Worker; workers?: { [index: string]: Worker | undefined @@ -1346,7 +1339,7 @@ declare module "cluster" { export var isWorker: boolean; // TODO: cluster.schedulingPolicy export var settings: ClusterSettings; - export function setupMaster(settings?: ClusterSetupMasterSettings): void; + export function setupMaster(settings?: ClusterSettings): void; export var worker: Worker; export var workers: { [index: string]: Worker | undefined