From 014cf4b92cc4fb14b5eebd7e9df6d6eac4f29067 Mon Sep 17 00:00:00 2001 From: Alex Macleod Date: Mon, 7 May 2018 19:38:39 +0100 Subject: [PATCH] firefox-webext-browser: remove bookmark.import/export (#25044) They aren't used by any browser and break the bookmarks namespace (no other properties are accessible on completion) --- .../firefox-webext-browser-tests.ts | 2 ++ types/firefox-webext-browser/index.d.ts | 16 ---------------- 2 files changed, 2 insertions(+), 16 deletions(-) mode change 100644 => 100755 types/firefox-webext-browser/index.d.ts diff --git a/types/firefox-webext-browser/firefox-webext-browser-tests.ts b/types/firefox-webext-browser/firefox-webext-browser-tests.ts index 38169d573a..53f3b5a928 100644 --- a/types/firefox-webext-browser/firefox-webext-browser-tests.ts +++ b/types/firefox-webext-browser/firefox-webext-browser-tests.ts @@ -12,3 +12,5 @@ browser._manifest.NativeManifest; // $ExpectError // browser.runtime const port = browser.runtime.connect(); port.postMessage(); // $ExpectError + +browser.bookmarks.getTree(); diff --git a/types/firefox-webext-browser/index.d.ts b/types/firefox-webext-browser/index.d.ts old mode 100644 new mode 100755 index d04b7f6aca..1ce4024f4d --- a/types/firefox-webext-browser/index.d.ts +++ b/types/firefox-webext-browser/index.d.ts @@ -3915,10 +3915,6 @@ declare namespace browser.bookmarks { type?: BookmarkTreeNodeType; } - export {_import as import}; - - export {_export as export}; - /* bookmarks functions */ /** * Retrieves the specified BookmarkTreeNode(s). @@ -3986,18 +3982,6 @@ declare namespace browser.bookmarks { /** Recursively removes a bookmark folder. */ function removeTree(id: string): Promise; - /** - * Imports bookmarks from an html bookmark file - * @deprecated Unsupported on Firefox at this time. - */ - function _import(): Promise; - - /** - * Exports bookmarks to an html bookmark file - * @deprecated Unsupported on Firefox at this time. - */ - function _export(): Promise; - /* bookmarks events */ /** Fired when a bookmark or folder is created. */ const onCreated: WebExtEvent<(id: string, bookmark: BookmarkTreeNode) => void>;