Michael Schneider
ce98e56352
Use getter of layout inspector to create it lazily and not have to create it at initialization time
2016-07-13 16:36:48 -07:00
Michael Schneider
8b3ec83bfd
Small name changes
2016-07-13 16:36:48 -07:00
Michael Schneider
d82a2e810f
Move methods regarding supplementary nodes to optional in ASCollectionViewLayoutInspecting
2016-07-13 16:36:48 -07:00
Michael Schneider
30bb2ee93d
Address comments from @levi
2016-07-13 16:36:48 -07:00
Michael Schneider
9fb3129a0e
Add default ASCollectionViewLayoutInspecting for custom ASCollectionViewLayout
2016-07-13 16:36:48 -07:00
Michael Schneider
35c860c183
Refactor usage of ASCollectionViewLayoutInspecting
...
- Fix not using itemSize of UICollectionViewFlowLayout
- Move automatic constrained size calculation to the ASCollectionViewFlowLayoutInspector
- Provide a null layout inspector for throwing exceptions if a custom
UICollectionView is given but no ASCollectionViewLayoutInspecting
- Fix not checking for optional layout inspecting data source methods
are implemented or not
- Improving tests around ASCollectionViewLayoutInspecting
2016-07-13 16:36:48 -07:00
Michael Schneider
6c8292470b
Merge pull request #1915 from maicki/RevertFixBuildingFrameworkXcode
...
Revert "Fix building framework in Xcode"
2016-07-13 15:30:47 -07:00
Michael Schneider
793e15132f
Revert "Fix building framework in Xcode"
...
This reverts commit 3b429f446e .
2016-07-13 15:06:56 -07:00
Adlai Holler
beba131839
Merge pull request #1914 from maicki/FixBuildingFrameworkXcode
...
Fix building framework in Xcode
2016-07-13 13:15:25 -07:00
Michael Schneider
3b429f446e
Fix building framework in Xcode
2016-07-13 12:10:25 -07:00
Michael Schneider
e30c76c5ad
Remove deprecated selected and highlighted methods ( #1909 )
2016-07-13 10:13:31 -07:00
Adlai Holler
464fa12a00
Merge pull request #1910 from feduza/overview-example-fix
...
[Examples] AsyncDisplayKitOverview collection nodes size fix
2016-07-13 09:31:08 -07:00
Fedor Vetoshko
12697f158f
AsyncDisplayKitOverview collection nodes size fix
2016-07-13 15:58:15 +03:00
Adlai Holler
e40597ec47
Merge pull request #1792 from george-gw/prMapNode
...
[ASMapNode] bug fixes + added the ability to zoom in on the annotations + example project
2016-07-12 14:42:47 -07:00
Adlai Holler
5d33ec178e
Merge pull request #1619 from Adlai-Holler/RangeControllerSynchronousness
...
[ASRangeController] Update Synchronously More Often
2016-07-12 14:42:28 -07:00
Adlai Holler
edb4e45c24
[ASRangeController] Update synchronously when possible
2016-07-12 14:36:20 -07:00
Adlai Holler
2e3da9bc92
Merge pull request #1903 from nguyenhuy/ASButtonNode_updateTitle
...
[ASButtonNode] Correctly compare and update its title
2016-07-12 11:34:22 -07:00
Michael Schneider
84029d133f
Merge pull request #1902 from maicki/MSFixLayoutTriggerFromSubnodeNotHappening
...
[ASDisplayNode] Fix setNeedsLayout triggered from subnode will not trigger relayout
2016-07-12 11:28:14 -07:00
Michael Schneider
dc2255d5d8
Fix setNeedsLayout triggered from subnode will not trigger relayout
2016-07-12 09:26:40 -07:00
Huy Nguyen
4b331be1e8
Correctly compare and update title of ASButtonNode
2016-07-12 21:25:22 +07:00
George A
396583dbaa
[ASMapNode] Protected showAnnotationsOptions with a lock.
2016-07-12 08:01:17 +02:00
Adlai Holler
6b44b5ac05
[ASTableView] Add retainedLayer a la collection view ( #1896 )
2016-07-11 20:22:45 -07:00
Michael Schneider
7f4737217e
Change from MutexLocker / MutexUnlocker to lock() and unlock() directly on property lock ( #1900 )
...
For performance reasons change to directly lock and unlock calls on the property lock instance
2016-07-11 17:04:47 -07:00
Michael Schneider
93ee42db57
Remove assert in visibleStateDidChange: in ASCellNode ( #1899 )
...
This assertion is failing in some apps and will be enabled soon.
2016-07-11 17:04:20 -07:00
Michael Schneider
137c70647d
Merge pull request #1892 from rcancro/finalLayoutableSetChildren
...
[ASLayoutSpec] Final layoutable set children
2016-07-11 14:31:35 -07:00
Michael Schneider
255e75a9be
Merge pull request #1893 from eJamesLin/fix_example_Multiplex_image_path
...
[Examples] fix image paths in example_extra/Multiplex
2016-07-11 14:20:10 -07:00
George A
41e26374e3
Removed debugging messages from ASMapNode's sample, they are no longer needed.
2016-07-11 20:52:48 +02:00
George A
f9629beabb
[ASMapNode] Defaulting userInteractionEnabled to YES.
2016-07-11 20:48:12 +02:00
Hannah Troisi
488db475f4
Update GITHUB_RULES.md
2016-07-11 11:22:11 -07:00
CJ Lin
f8e294bc23
fix image paths in example_extra/Multiplex
2016-07-12 01:36:41 +08:00
ricky
0696ea87b7
fixed trait example
2016-07-11 09:59:22 -07:00
ricky
57ece0f46e
[ASLayoutSpec] Bug where finalLayoutable was not being called for setChildren
2016-07-11 09:54:03 -07:00
George A
69ca67b578
Code cleaning and fixes based on code review.
2016-07-11 10:43:19 +02:00
Scott Goodson
012c927cd8
[ASLayout] Small optimization to eliminate one method call in an extremely hot codepath.
...
This was observed with quantitative profiling results. We have some opportunities to micro-optimize the layout objects.
2016-07-10 23:02:39 -07:00
Hannah Troisi
a8f01fb13b
Merge pull request #1887 from facebook/fixASDKgram
...
Remove UIKit call from -init!
2016-07-10 21:19:14 -07:00
Hannah Trosi
2317e17c53
Remove UIKit call from -init!1
2016-07-10 21:17:32 -07:00
Hannah Troisi
1d93dbc0b3
Add files via upload
2016-07-10 20:12:36 -07:00
Hannah Troisi
cf010176b4
Update .gitignore
2016-07-10 19:06:40 -07:00
Hannah Trosi
bd6e85e59d
Remove old (original website) files from repository
2016-07-10 19:03:34 -07:00
Hannah Troisi
b9c9e6be5b
Update README.md
2016-07-10 18:59:07 -07:00
appleguy
a9e3eacfe5
[ASCellNode] Add gating for -convertRect: call upon invisibility notification for iOS 7 & 8 edge case. ( #1881 )
...
* [ASCellNode] Add gating for -convertRect: call upon invisibility notification for iOS 7 & 8 edge case.
This should resolve https://github.com/facebook/AsyncDisplayKit/issues/1659 , which corresponds to this
Fabric log for Pinterest: https://fabric.io/pinterest6/ios/apps/com.pinterest.enterprise/issues/5776fbfeffcdc042501a5f20/sessions/c178e977614b4ebab853084847fb241
8
* [ASCellNode] Additional improvements to visibilityDidChange: gating.
2016-07-10 16:01:55 -07:00
Hannah Trosi
5856bd3b59
[Cocoapods] Update podspec with 1.9.81
1.9.81
2016-07-10 12:53:44 -07:00
Flo
2e65339f33
[ASVideoNode, ASVideoPlayerNode] Add video composition and audio mix capabilities ( #1800 )
...
* [ASVideoNode] Add delegate method called when the currentItem is set.
* [ASVideoNode] Add videoComposition and audioMix properties to the ASVideoNode.
* [ASVideoPlayerNode] Add new initialiser with videoComposition and audioMix, and forward new delegate method.
* [ASVideoPlayerNode] Forward missing ASVideoNodeDelegate methods.
2016-07-10 11:32:21 -07:00
Hannah Troisi
10447998af
[ASMapNode] use ASDisplayNode base class lock ( #1879 )
...
* [ASVideoPlayerNode] Use ASDisplayNode base class lock for subclass property syncrhonization, fix retain cycles
* [ASMapNode] Use ASDisplayNode base class lock instead of subclass lock
2016-07-10 00:30:37 -07:00
Scott Goodson
bf9c142765
Revert "[ASTextNode] Fix text node truncation ( #1863 )"
...
This reverts commit 6238e5edbd .
We will re-apply this change, but there are some early signs of performance impacts that need to be investigated.
2016-07-09 23:54:43 -07:00
Scott Goodson
d83f319fe3
Revert "Use textStorageCreationBlock for resetting the text storage ( #1874 )"
...
This reverts commit d646d3c753 .
2016-07-09 23:54:28 -07:00
Hannah Troisi
ff7a586eba
[ASVideoPlayerNode] Use ASDisplayNode base class lock for subclass property syncrhonization, fix retain cycles ( #1878 )
2016-07-09 23:51:49 -07:00
Scott Goodson
1d07759c9e
[ASDisplayNode+AsyncDisplay] Add locking for _flags (although write-once-on-init, this quiets the Thread Sanitizer).
2016-07-09 23:50:40 -07:00
Eric Horacek
3efd01a781
[ASCollectionDataController] Repopulate deleted supplementary nodes if necessary ( #1773 )
...
* Repopulate deleted supplementary nodes if necessary
Fixes 1771
* Fix warning
2016-07-09 22:46:29 -07:00
Hannah Troisi
f39c2ce7e3
[ASTextNode, ASImageNode, ASVideoNode] Use ASDisplayNode base class lock for subclass property synchronization ( #1877 )
...
* [ASTextNode, ASVideoNode] Use ASDisplayNode base class lock for subclass property synchronization
* fix headers to match master
* address @appleguy, @maicki comments
* import header
* Swap lock in ASNetworkImageNode as well
* remove invalid comment
* more cleanup of locks
2016-07-09 22:08:34 -07:00