kylefang/AsyncDisplayKit
1
0
Fork 0
mirror of https://github.com/HackPlan/AsyncDisplayKit.git synced 2026-04-24 03:45:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1550 from maicki/FixArrayDiffStaticAnalyzer

Browse Source 
[NSArray+Diffing] Static analyzer issue with common indexes algorithm in _asdk_commonIndexesWithArray:
This commit is contained in:
appleguy
2016-04-18 22:01:29 -07:00
parent 8d0fe9650b 9d07336c75
commit f9d00eea93
2 changed files with 66 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
AsyncDisplayKitTests/ArrayDiffingTests.m
View File

@@ -10,13 +10,58 @@
#import "NSArray+Diffing.h"
@interface NSArray (ArrayDiffingTests)
- (NSIndexSet *)_asdk_commonIndexesWithArray:(NSArray *)array compareBlock:(BOOL (^)(id lhs, id rhs))comparison;
@end
@interface ArrayDiffingTests : XCTestCase
@end
@implementation ArrayDiffingTests
- (void)testDiffing {
- (void)testDiffingCommonIndexes
{
NSArray<NSArray *> *tests = @[
@[
@[@"bob", @"alice", @"dave"],
@[@"bob", @"alice", @"dave", @"gary"],
@[@0, @1, @2]
],
@[
@[@"bob", @"alice", @"dave"],
@[@"bob", @"gary", @"dave"],
@[@0, @2]
],
@[
@[@"bob", @"alice"],
@[@"gary", @"dave"],
@[],
],
@[
@[@"bob", @"alice", @"dave"],
@[],
@[],
],
@[
@[],
@[@"bob", @"alice", @"dave"],
@[],
],
];
for (NSArray *test in tests) {
NSIndexSet *indexSet = [test[0] _asdk_commonIndexesWithArray:test[1] compareBlock:^BOOL(id lhs, id rhs) {
return [lhs isEqual:rhs];
}];
for (NSNumber *index in (NSArray *)test[2]) {
XCTAssert([indexSet containsIndex:[index integerValue]]);
}
}
}
- (void)testDiffingInsertionsAndDeletions {
NSArray<NSArray *> *tests = @[
@[
@[@"bob", @"alice", @"dave"],