kylefang/AsyncDisplayKit
1
0
Fork 0
mirror of https://github.com/HackPlan/AsyncDisplayKit.git synced 2026-03-29 08:39:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ASTextNode] Fix ASTextNode shadow is not rendering (#2042)

Browse Source 
* Passing through shadow in renderer attribute

* Fix memory leak setting shadow color
This commit is contained in:
Michael Schneider
2016-08-09 14:56:59 -07:00
committed by Hannah Trosi
parent 99d2a3ced0
commit c5753c44ea
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
AsyncDisplayKit/ASTextNode.mm
View File

@@ -44,6 +44,7 @@ struct ASTextNodeDrawParameter {
@implementation ASTextNode {
CGSize _shadowOffset;
CGColorRef _shadowColor;
UIColor *_cachedShadowUIColor;
CGFloat _shadowOpacity;
CGFloat _shadowRadius;
@@ -244,6 +245,10 @@ static NSArray *DefaultLinkAttributeNames = @[ NSLinkAttributeName ];
.pointSizeScaleFactors = self.pointSizeScaleFactors,
.layoutManagerCreationBlock = self.layoutManagerCreationBlock,
.textStorageCreationBlock = self.textStorageCreationBlock,
.shadowOffset = _shadowOffset,
.shadowColor = _cachedShadowUIColor,
.shadowOpacity = _shadowOpacity,
.shadowRadius = _shadowRadius
};
}
@@ -1055,7 +1060,11 @@ static CGRect ASTextNodeAdjustRenderRectForShadowPadding(CGRect rendererRect, UI
if (shadowColor != NULL) {
CGColorRetain(shadowColor);
}
if (_shadowColor != NULL) {
CGColorRelease(_shadowColor);
}
_shadowColor = shadowColor;
_cachedShadowUIColor = [UIColor colorWithCGColor:shadowColor];
[self _invalidateRenderer];
[self setNeedsDisplay];
}