kylefang/AsyncDisplayKit
1
0
Fork 0
mirror of https://github.com/HackPlan/AsyncDisplayKit.git synced 2026-04-24 11:56:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Unify boolean flag naming confention, getter spacing, and property attribute naming

Browse Source 
Summary:
* Fixes #3
* Ordering: atomicity, then [optional] readonly, then value semantics (retain/copy/assign)
* Removed redundant `readwrite`
* No spaces between "getter = name" ("getter=name" instead)
* Property method overrides renamed as well
* self.isBlah, while technically not entirely correct, still resolves to [self blah], so left alone (@kimon had advice on this sort of naming issue last summer), and largely inconsequential

Test Plan:
* Compile and run
This commit is contained in:
Andrew Toulouse
2014-07-16 15:57:18 -07:00
parent f504ab4d15
commit a35c109a08
16 changed files with 44 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
AsyncDisplayKitTests/ASDisplayNodeAppearanceTests.m
View File

@@ -132,7 +132,7 @@ static dispatch_block_t modifyMethodByAddingPrologueBlockAndReturnCleanupBlock(C
DeclareNodeNamed(n);
DeclareViewNamed(superview);
n.isLayerBacked = isLayerBacked;
n.layerBacked = isLayerBacked;
if (isLayerBacked) {
[superview.layer addSublayer:n.layer];
@@ -179,7 +179,7 @@ static dispatch_block_t modifyMethodByAddingPrologueBlockAndReturnCleanupBlock(C
DeclareNodeNamed(ab);
for (ASDisplayNode *n in @[parent, a, b, aa, ab]) {
n.isLayerBacked = isLayerBacked;
n.layerBacked = isLayerBacked;
if (isViewLoaded)
[n layer];
}
@@ -273,7 +273,7 @@ static dispatch_block_t modifyMethodByAddingPrologueBlockAndReturnCleanupBlock(C
DeclareNodeNamed(layerBackedNode);
DeclareNodeNamed(viewBackedNode);
layerBackedNode.isLayerBacked = YES;
layerBackedNode.layerBacked = YES;
UIWindow *window = [[UIWindow alloc] initWithFrame:CGRectZero];
[parentSynchronousNode addSubnode:layerBackedNode];
@@ -326,7 +326,7 @@ static dispatch_block_t modifyMethodByAddingPrologueBlockAndReturnCleanupBlock(C
DeclareNodeNamed(childSubnode);
for (ASDisplayNode *n in @[parentA, parentB, child, childSubnode]) {
n.isLayerBacked = isLayerBacked;
n.layerBacked = isLayerBacked;
}
[parentA addSubnode:child];