kylefang/AsyncDisplayKit
1
0
Fork 0
mirror of https://github.com/HackPlan/AsyncDisplayKit.git synced 2026-04-24 03:45:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Disable ASTextKitRenderer cache (#2315)

Browse Source
This commit is contained in:
Michael Schneider
2016-09-28 13:42:06 -07:00
committed by Adlai Holler
parent 87595c7d3b
commit 4aa7c9631d
1 changed files with 29 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
AsyncDisplayKit/ASTextNode.mm
View File

@@ -82,16 +82,16 @@ ASDISPLAYNODE_INLINE NSUInteger ASHashFromCGSize(CGSize size)
@end
static NSCache *sharedRendererCache()
{
static dispatch_once_t onceToken;
static NSCache *__rendererCache = nil;
dispatch_once(&onceToken, ^{
__rendererCache = [[NSCache alloc] init];
__rendererCache.totalCostLimit = 500; // 500 renders cache
});
return __rendererCache;
}
//static NSCache *sharedRendererCache()
//{
// static dispatch_once_t onceToken;
// static NSCache *__rendererCache = nil;
// dispatch_once(&onceToken, ^{
// __rendererCache = [[NSCache alloc] init];
// __rendererCache.totalCostLimit = 500; // 500 renders cache
// });
// return __rendererCache;
//}
/**
The concept here is that neither the node nor layout should ever have a strong reference to the renderer object.
@@ -99,24 +99,29 @@ static NSCache *sharedRendererCache()
we maintain a LRU renderer cache that is queried via stack-allocated keys.
*/
// Disabled renderer cache for now
//static ASTextKitRenderer *rendererForAttributes(ASTextKitAttributes attributes, CGSize constrainedSize)
//{
// NSCache *cache = sharedRendererCache();
//
// ASTextNodeRendererKey *key = [[ASTextNodeRendererKey alloc] init];
// key.attributes = attributes;
// key.constrainedSize = constrainedSize;
//
// ASTextKitRenderer *renderer = [cache objectForKey:key];
// if (renderer == nil) {
// renderer = [[ASTextKitRenderer alloc] initWithTextKitAttributes:attributes constrainedSize:constrainedSize];
// [cache setObject:renderer forKey:key cost:1];
// }
//
// return renderer;
//}
static ASTextKitRenderer *rendererForAttributes(ASTextKitAttributes attributes, CGSize constrainedSize)
{
NSCache *cache = sharedRendererCache();
ASTextNodeRendererKey *key = [[ASTextNodeRendererKey alloc] init];
key.attributes = attributes;
key.constrainedSize = constrainedSize;
ASTextKitRenderer *renderer = [cache objectForKey:key];
if (renderer == nil) {
renderer = [[ASTextKitRenderer alloc] initWithTextKitAttributes:attributes constrainedSize:constrainedSize];
[cache setObject:renderer forKey:key cost:1];
}
return renderer;
return [[ASTextKitRenderer alloc] initWithTextKitAttributes:attributes constrainedSize:constrainedSize];
}
#pragma mark - ASTextNode
struct ASTextNodeDrawParameter {